Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: set default enableConnectProtocol to 0 #31174

Closed
wants to merge 2 commits into from
Closed

http2: set default enableConnectProtocol to 0 #31174

wants to merge 2 commits into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Jan 3, 2020

According to rfc8441:

9.1.  A New HTTP/2 Setting

   This document registers an entry in the "HTTP/2 Settings" registry
   that was established by Section 11.3 of [RFC7540].

      Code: 0x8
      Name: SETTINGS_ENABLE_CONNECT_PROTOCOL
      Initial Value: 0
      Specification: This document

The initial value of SETTINGS_ENABLE_CONNECT_PROTOCOL is 0, so added DEFAULT_SETTINGS_ENABLE_CONNECT_PROTOCOL, and we can access this using http2.getDefaultSettings():

> http2.getDefaultSettings()
[Object: null prototype] {
  headerTableSize: 4096,
  enablePush: true,
  initialWindowSize: 65535,
  maxFrameSize: 16384,
  maxConcurrentStreams: 4294967295,
  maxHeaderListSize: 65535,
  enableConnectProtocol: false
}

Refs: rfc8441

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 3, 2020
@ZYSzys ZYSzys added the http2 Issues or PRs related to the http2 subsystem. label Jan 3, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28207/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28213/

@Trott
Copy link
Member

Trott commented Jan 6, 2020

Landed in 66310c2

@Trott Trott closed this Jan 6, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 6, 2020
@ZYSzys @Trott
http2: set default enableConnectProtocol to 0
66310c2 
PR-URL: nodejs#31174
Refs: https://tools.ietf.org/html/rfc8441#section-9.1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ZYSzys ZYSzys deleted the http2-enable-connect-protocol branch January 6, 2020 05:01
targos pushed a commit that referenced this pull request Jan 6, 2020
@ZYSzys @targos
http2: set default enableConnectProtocol to 0
b5a71a4 
PR-URL: #31174
Refs: https://tools.ietf.org/html/rfc8441#section-9.1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ZYSzys @targos
http2: set default enableConnectProtocol to 0
5076c59 
PR-URL: #31174
Refs: https://tools.ietf.org/html/rfc8441#section-9.1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
@ZYSzys @targos
http2: set default enableConnectProtocol to 0
20a8175 
PR-URL: #31174
Refs: https://tools.ietf.org/html/rfc8441#section-9.1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ZYSzys @BethGriggs
http2: set default enableConnectProtocol to 0
5dd7c92 
PR-URL: #31174
Refs: https://tools.ietf.org/html/rfc8441#section-9.1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ZYSzys @nodejs-github-bot @Trott @jasnell @cjihrig @BridgeAR